Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial fixes #415

Merged
merged 2 commits into from
May 6, 2024
Merged

Trivial fixes #415

merged 2 commits into from
May 6, 2024

Conversation

ydah
Copy link
Collaborator

@ydah ydah commented May 5, 2024

  • Remove unnecessary empty line
  • Enclose in parentheses where you assign in the if condition

@yui-knk
Copy link
Collaborator

yui-knk commented May 6, 2024

Could you rebase master to resolve conflict when you have time?

@ydah ydah force-pushed the trivial-fixes branch from b0241ee to 1fe6101 Compare May 6, 2024 01:14
@ydah
Copy link
Collaborator Author

ydah commented May 6, 2024

Thank you. I updated this PR.

@yui-knk yui-knk merged commit 2610288 into ruby:master May 6, 2024
16 checks passed
@ydah ydah deleted the trivial-fixes branch May 6, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yui-knk yui-knk yui-knk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydah @yui-knk