-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide standard library as stdlib.y #344
Conversation
c8dccbc
to
2ca1f91
Compare
I agree to the direction to define standard library in "stdlib.y" file, it makes clear for us what's each standard rule means. standard library by default or notI think it's better to enable standard library by default. If some rules don't match with user's expectation, user can (or should be able to) overwrite the rule by themselves with writing same name parameterizing rule in their grammar file. I aslo concern about the location where My suggestion is to make standard library by default. The location of "stdlib.y""stdlib.y" needs to be included into gem package and https://github.com/ruby/ruby/tree/master/tool/lrama. We can manage both of them by configuring "lrama.gemspec" and changing install script. But I feel it's good to put "stdlib.y" under "lib", e.g. "lib/lrama/grammar/". |
2d39c5b
to
20aa05d
Compare
Thank you for the review. I agree that it should be enabled by default. The documentation has also been updated as per the current design. |
Left some comments, others seems good to me! |
5b92f08
to
6786de3
Compare
Thank you for the review! I have updated this PR. |
6786de3
to
7ac1f17
Compare
Thank you for the review! I have updated this PR. |
Excellent job 💯 |
doc: https://gist.github.com/ydah/fda6f4abac4ce34547fe90143eba33f2