Lazy reference resolution #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule build process is a bit complicated. `new_token` (`"@1"`) is created when derived rule is created. Original rule requires `new_token`, but derived rule needs to refer to original rule. We can avoid such complex order of rule generation by lazy reference resolution. This PR also fixes a bug of derived rule for mid rule action referring to wrong LHS, mentioned by ruby#195 (comment)
yui-knk
force-pushed
the
lazy_reference_resolution
branch
from
421c873 to
f15e68e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule build process is a bit complicated.
new_token("@1") is createdwhen derived rule is created. Original rule requires
new_token, butderived rule needs to refer to original rule.
We can avoid such complex order of rule generation by lazy reference resolution.
This PR also fixes a bug of derived rule for mid rule action referring to wrong LHS, mentioned by #195 (comment)