Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support // style comment #13

Merged
merged 2 commits into from
May 16, 2023
Merged

Support // style comment #13

merged 2 commits into from
May 16, 2023

Conversation

makenowjust
Copy link
Contributor

I'm not familiar with YACC/Bison, so I'm not sure if this fix is the correct and expected one. I welcome any comments.

@yui-knk
Copy link
Collaborator

yui-knk commented May 16, 2023

@makenowjust Thanks for the PR. Bison supports // style comment, https://www.gnu.org/software/bison/manual/html_node/Grammar-Outline.html, therefore I want to merge this PR.
Regarding tests, can I ask you to add the test case for https://github.com/ruby/lrama/pull/13/files#diff-816037370d9ebaadd970a429ac66cdf5597623e3f285642396489c85b05b89c5R209 ? Adding // style comment to

%token tEQEQ "=="
is enough.

@makenowjust
Copy link
Contributor Author

Thank you, @yui-knk. I added a test-case for // style comment in lex_common.

@yui-knk yui-knk merged commit d448102 into ruby:master May 16, 2023
@yui-knk
Copy link
Collaborator

yui-knk commented May 16, 2023

Thank you!

@makenowjust makenowjust deleted the line-comment branch May 16, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants