Use parentheses for assignment in conditions

ruby · Dec 23, 2023 · 0fc68a9 · 0fc68a9
1 parent af9d865
commit 0fc68a9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/lrama/grammar.rb b/lib/lrama/grammar.rb
@@ -74,7 +74,7 @@ def add_term(id:, alias_name: nil, tag: nil, token_id: nil, replace: false)
         return sym
       end
 
-      if sym = @symbols.find {|s| s.id == id }
+      if (sym = @symbols.find {|s| s.id == id })
         return sym
       end
 

diff --git a/lib/lrama/grammar/rule_builder.rb b/lib/lrama/grammar/rule_builder.rb
@@ -156,7 +156,7 @@ def numberize_references
                   raise location.generate_error_message("Referring symbol `#{ref_name}` is duplicated.")
                 end
 
-                unless referring_symbol = candidates.first
+                unless (referring_symbol = candidates.first)
                   location = token.location.partial_location(ref.first_column, ref.last_column)
                   raise location.generate_error_message("Referring symbol `#{ref_name}` is not found.")
                 end
@@ -179,7 +179,7 @@ def numberize_references
       end
 
       def flush_user_code
-        if c = @user_code
+        if (c = @user_code)
           @rhs << c
           @user_code = nil
         end

diff --git a/lib/lrama/states_reporter.rb b/lib/lrama/states_reporter.rb
@@ -156,7 +156,7 @@ def report_states(io, itemsets, lookaheads, solved, counterexamples, verbose)
           nl = true
         end
 
-        if r = state.default_reduction_rule
+        if (r = state.default_reduction_rule)
           nl = true
           s = "$default".ljust(max_len)