Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for changing severity using bang methods. #15

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Add support for changing severity using bang methods. #15

merged 1 commit into from
Mar 15, 2019

Conversation

ioquatix
Copy link
Member

This is a proposal to make it easier for 3rd party implementations to support same interface without depending on Logger constants.

Rather than writing logger.level = Logger::DEBUG, we can write logger.debug!. I believe this is better since it is aligned with the "Ask, don't tell" software design pattern.

@sonots
Copy link
Member

sonots commented Mar 15, 2019

I like this. I am going to merge.

@sonots sonots merged commit 7651447 into ruby:master Mar 15, 2019
@ioquatix
Copy link
Member Author

Awesome. Do you mind waiting for me to add more documentation?

@ioquatix
Copy link
Member Author

I will commit documentation directly to master.

@sonots-zozo
Copy link

it is okay for me, thank you for your documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants