bump version to 1.3.0 · ruby/logger@7872500 · GitHub

Commit

bump version to 1.3.0

Browse files

Loading branch information

hsbt committed Dec 5, 2018

1 parent 0eb6a21 commit 7872500

lib/logger.rb

-Original file line number
+Diff line change
@@ Expand Up / @@ -224,7 +224,7 @@ @@
     #   })
     #
     class Logger
-      VERSION = "1.2.7"
+      VERSION = "1.3.0"
       _, name, rev = %w$Id$
       if name
         name = name.chomp(",v")
@@ Expand Down @@

4 comments on commit `7872500`

giovanic commented on `7872500` Dec 13, 2018

Hello good morning, my name and giovani, we used the gem log in version 1.2.8, we noticed that this version was removed and with that I was updated here for us for version 1.3.0. Here we use ruby 1.8.7 and this is giving a syntax error after the gem logger version. Please check back as soon as possible because we are having this syntax error.
Errors like this are occurring:

.rbenv/versions/1.8.7-p375/lib/ruby/gems/1.8/gems/logger-1.3.0/lib/logger.rb:378: syntax error, unexpected ':', expecting '=' progname: nil, formatter: nil, datetime_format: nil

Member

yuki24 commented on `7872500` Dec 13, 2018 •

edited

Loading

I don't think we still maintain support for Ruby 1.8 as it's been deprecated way long ago. The error indicates that 1.8 couldn't parse the keyword argument syntax, which was introduced in Ruby 2.0. Try using a version that's compatible with 1.8. Also, I would highly recommend upgrading to a newer version of Ruby.

giovanic commented on `7872500` Dec 13, 2018

Hello good afternoon
Is that according to the site RubyGems this gem is supported by all versions of ruby and I can not at the moment update my ruby. Could you kindly tell me why you did the gem logger version 1.2.8 exclusion?

Member

yuki24 commented on `7872500` Dec 13, 2018 •

edited

Loading

We didn't specify spec.required_ruby_version in the gemspec when we should have done. The last version was released more than 10 years ago and since then we've introduced a bunch of new features to the Ruby core. It's nearly impossible to maintain support for versions that are more than 10 years old due to the complexity added to the code base. I could be wrong, but I think the logger module is part of the stdlib in 1.8 so you don't have to add it to your Gemfile. "I can't upgrade my ruby" is a common counter, but that only makes your life harder, and it's your responsibility to find the path to upgrade Ruby in your organization. Regardless, we are not going to (and can really not) bring back the support for older versions.

Please sign in to comment.