Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easter egg for autocomplete mode #737

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented Oct 21, 2023

When you enter RubyVM[TAB], IRB shows an easter egg instead of document in irb --noautocomplete mode if ENV['RUBY_YES_I_AM_NOT_A_NORMAL_USER'] is not set.
I beleave this is to avoid normal user easily use RubyVM, but this feature(?) was not working in autocomplete mode.

This pull request adds easter egg for autocomplete mode. Shows easter egg ruby logo inside document dialog, shows more easter egg (:dancing and :logo) when alt+d is pressed.

dialog_easteregg

@tompng tompng force-pushed the autocomplete_easteregg_dialog branch from aaae70d to 7669d40 Compare October 22, 2023 06:21
@tompng tompng force-pushed the autocomplete_easteregg_dialog branch from 7669d40 to 0519c57 Compare October 22, 2023 06:33
@tompng tompng force-pushed the autocomplete_easteregg_dialog branch from 0519c57 to 4e737d2 Compare October 22, 2023 14:34
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💎

image

@tompng tompng merged commit a8e5cc7 into ruby:master Oct 28, 2023
24 checks passed
@tompng tompng deleted the autocomplete_easteregg_dialog branch October 28, 2023 14:47
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 28, 2023
(ruby/irb#737)

* Show easter-egg inside document dialog in autocomplete mode

* Show more easter_egg(dancing or logo) when Alt+d is pressed in autocomplete mode

ruby/irb@a8e5cc7354
@tompng
Copy link
Member Author

tompng commented Oct 28, 2023

data is generated by https://gist.github.com/tompng/696e978363535ce7289d105a2200b226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants