Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling exit if irb_context is nil #727

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Oct 11, 2023

ruby/ruby master is randomly experiencing this error:

  D:/a/ruby/ruby/src/lib/irb/extend-command.rb:25:in `irb_exit': private method `exit' called for nil (NoMethodError)
  
        irb_context.exit(ret)
                   ^^^^^
  	from D:/a/ruby/ruby/src/tool/test/runner.rb:23:in `<top (required)>'
  	from ../src/test/runner.rb:16:in `require_relative'
  	from ../src/test/runner.rb:16:in `<main>'

I'm not sure how to deterministically reproduce this issue (I suspect there's a loading order that could mess this up), but since it's failing on a nil receiver, we could address this by checking if the receiver is nil.

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will take a look

@st0012 st0012 merged commit 9c06f9e into ruby:master Oct 12, 2023
47 checks passed
@k0kubun k0kubun deleted the fix-ruby-ci branch October 12, 2023 00:19
@tompng tompng mentioned this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants