Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pager in show-source test #720

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented Sep 23, 2023

Test was failing with rake test | ruby -e "loop{puts gets || exit}"

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can make it a general setup for CommandTestCase?
Also, I'm curious about the reason to run rake test | ruby -e "loop{puts gets || exit}"

@tompng tompng force-pushed the show_source_test_no_tty branch from 46d0c36 to 91fde7c Compare September 25, 2023 14:30
@tompng
Copy link
Member Author

tompng commented Sep 25, 2023

general setup for CommandTestCase

done 👍

I found a blog post https://jinroq.hatenablog.jp/entry/2023/09/23/191254 that says ShowSourceTest is failing.

I don't know how the test is executed, but I found that rake test succeed and rake test | any_command failed.
rake test > test_output.txt also fails.

@tompng tompng merged commit 5669efa into ruby:master Sep 26, 2023
24 checks passed
@tompng tompng deleted the show_source_test_no_tty branch September 26, 2023 10:06
matzbot pushed a commit to ruby/ruby that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants