Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test warnings #698

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix test warnings #698

merged 2 commits into from
Aug 29, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 28, 2023

  1. Encodings should be saved before creating Irb objects as the creation itself changes the encoding already.
  2. Avoid assigning the out variable when it's not needed.

@st0012 st0012 self-assigned this Aug 28, 2023
@st0012 st0012 requested a review from a team August 28, 2023 11:24
@tompng tompng merged commit 036ec31 into master Aug 29, 2023
@tompng tompng deleted the fix-encoding-change branch August 29, 2023 12:48
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 29, 2023
@st0012 @matzbot
[ruby/irb] Fix test warnings (ruby/irb#698)
0cfb779 
* Encoding should be saved before creating Irb objects

* Fix unused local warning

ruby/irb@036ec31034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tompng tompng tompng approved these changes

Assignees

@st0012 st0012

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @tompng