Fix indentation of xstring literal #1038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong indent calculation of this input
Description
We need to distinguish
Kernel.`
from`xstring_literal`
.`ls`
:on_backtick
EXPR_BEG
class `ls`::A;end
:on_backtick
EXPR_CLASS
p `ls`
:on_backtick
EXPR_CMDARG
p x: `ls`
:on_backtick
EXPR_ARG|EXPR_LABELED
p(`ls`)
:on_backtick
EXPR_BEG|EXPR_LABEL
Kernel.`
:on_backtick
EXPR_ARG
The simplest way to check is using
state != EXPR_ARG
.Known issues
As shown in the table below, checking by
state != EXPR_ARG
is not perfect. But there is no easy way.p p `ls`
:on_backtick
EXPR_ARG
Kernel.`
:on_backtick
EXPR_ARG