Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rubocop-on-rbs to activestorage #771

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Jan 19, 2025

Offenses:

gems/activestorage/6.1/lib/attached/model.rbs:50:39: C: [Corrected] RBS/Layout/SpaceAroundOperators: Use one space before |.
        ?service: (::String | ::Symbol| nil) service,
                                      ^
gems/activestorage/6.1/lib/attached/model.rbs:96:39: C: [Corrected] RBS/Layout/SpaceAroundOperators: Use one space before |.
        ?service: (::String | ::Symbol| nil) service,
                                      ^

632 files inspected, 2 offenses detected, 2 offenses corrected

Copy link

@ksss Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activestorage

You changed RBS files for an existing gem.
You can merge this PR yourself because you are a reviewer of this gem.
Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.

@ksss
Copy link
Collaborator Author

ksss commented Jan 19, 2025

/merge

@github-actions github-actions bot merged commit ce44437 into ruby:main Jan 19, 2025
6 checks passed
@ksss ksss deleted the rubocop-activestorage branch January 19, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant