-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activerecord: Add types for strict_loading #755
Conversation
@dak2 Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVE
/merge |
- strict_loading(value = true) - https://api.rubyonrails.org/v6.1.7.3/classes/ActiveRecord/QueryMethods.html#method-i-strict_loading - strict_loading?() - https://api.rubyonrails.org/v6.1.7.3/classes/ActiveRecord/Core.html#method-i-strict_loading-3F - strict_loading!() - https://api.rubyonrails.org/v6.1.7.3/classes/ActiveRecord/Core.html#method-i-strict_loading-21 * Arguments have been added to strict_loading! since 7.0. - up to 6.1 - https://api.rubyonrails.org/v6.1.7.3/classes/ActiveRecord/Core.html#method-i-strict_loading-21 - since 7.0 - https://api.rubyonrails.org/v7.0/classes/ActiveRecord/Core.html#method-i-strict_loading-21 This methods have been added since 6.1. rails/rails#37400
726037e
to
4bd699c
Compare
/merge |
This PR is not approved yet by the reviewers. Please get approval from the reviewers. See the Actions tab for detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVE
/merge |
Thanks! |
Add types for below three methods.
Arguments have been added to strict_loading! since 7.0.
This methods have been added since 6.1.
rails/rails#37400