Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activerecord: add ActiveRecord::Core#values_at #752

Merged
merged 1 commit into from
Dec 16, 2024
Merged

activerecord: add ActiveRecord::Core#values_at #752

merged 1 commit into from
Dec 16, 2024
+24 −0

Conversation

dak2
Copy link
Contributor

@dak2 dak2 commented Dec 15, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

@dak2 Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

tk0miya
tk0miya reviewed Dec 15, 2024
View reviewed changes
gems/activerecord/6.1/activerecord-6.1.rbs
Comment on lines +9 to +11
module Core
def values_at: (*Symbol | String) -> Array[untyped]
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make copies of this signature to other versions?
It would be nice if we could provide this type for Rails-7.0, 7.1 and 7.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk0miya

I copied this signature to other versions without 6.0.
Thanks!

@dak2 dak2 force-pushed the activerecord/core/values_at branch from 3fd2eea to df22cec Compare December 15, 2024 13:06
@dak2 dak2 requested a review from tk0miya December 15, 2024 13:11
tk0miya
tk0miya reviewed Dec 15, 2024
View reviewed changes
Copy link
Contributor

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@github-actions GitHub Actions
Copy link

Thanks for your review, @tk0miya!

@dak2, @tk0miya This PR is ready to be merged.
Just comment /merge to merge this PR.

@dak2
Copy link
Contributor Author

dak2 commented Dec 16, 2024

/merge

@github-actions github-actions bot merged commit 56038c8 into ruby:main Dec 16, 2024
5 checks passed
@dak2 dak2 deleted the activerecord/core/values_at branch December 16, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tk0miya tk0miya tk0miya left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dak2 @tk0miya