Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manifest.yaml path from CI #495

Closed
wants to merge 1 commit into from
Closed

Fix manifest.yaml path from CI #495

wants to merge 1 commit into from

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Jan 8, 2024

When run from CI, the script was being run from the _test dir, so the manifest.yaml was not being checked.

@ksss ksss requested a review from pocke as a code owner January 8, 2024 15:05
soutaro
soutaro approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pocke pocke mentioned this pull request Jan 25, 2024
Merged
@pocke pocke closed this in #504 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

@pocke pocke Awaiting requested review from pocke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro