Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shoryuken #494

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Update shoryuken #494

merged 3 commits into from
Jan 25, 2024

Conversation

HoneyryderChuck
Copy link
Contributor

Add missing types, such as middleware and main singleton methods used in default integrations.

@HoneyryderChuck HoneyryderChuck requested a review from pocke as a code owner January 8, 2024 12:37
@HoneyryderChuck HoneyryderChuck force-pushed the update-shoryuken branch 3 times, most recently from 8e4d7ab to 28a277f Compare January 8, 2024 12:50
soutaro
soutaro approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pocke pocke mentioned this pull request Jan 25, 2024
Merged
@pocke pocke merged commit ccd9a07 into ruby:main Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

@pocke pocke Awaiting requested review from pocke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HoneyryderChuck @soutaro @pocke