active_hash: Fix ActiveHash::Base.find does not return nil #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It raises an exception if the target entry not found. Therefore it would be better to use non-optional types for its retval.
tk0miya
force-pushed
the
update_active_hash_find
branch
from
1f68f7b to
eedd11d
Compare
pocke
approved these changes
Oct 28, 2023
sw-square
pushed a commit
to sw-square/gem_rbs_collection
that referenced
this pull request
Jan 22, 2024
It raises an exception if the target entry not found. Therefore it would be better to use non-optional types for its retval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It raises an exception if the target entry not found. Therefore it would be better to use non-optional types for its retval.