Add types for Regexp::Parser#parse in regexp_parser gem #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m11o
commented
Oct 19, 2023
| class Regexp::Parser | ||
| def parse: (Regexp | String input, ?String? syntax, ?options: Integer?) { (Regexp::Expression::Root) -> untyped } -> untyped | ||
| | (Regexp | String input, ?String? syntax, ?options: Integer?) -> Regexp::Expression::Root | ||
| def self.parse: (Regexp | String input, ?String? syntax, ?options: Integer?) { (Regexp::Expression::Root) -> untyped } -> untyped |
There was a problem hiding this comment.
| @@ -0,0 +1,17 @@ | |||
| class Regexp::Parser | |||
| def parse: (Regexp | String input, ?String? syntax, ?options: Integer?) { (Regexp::Expression::Root) -> untyped } -> untyped | |||
There was a problem hiding this comment.
pocke
approved these changes
Oct 28, 2023
sw-square
pushed a commit
to sw-square/gem_rbs_collection
that referenced
this pull request
Jan 22, 2024
* Add types for Regexp::Parser#parse in regexp_parser gem Add RBS file for [email protected] ref: https://github.com/ammar/regexp_parsers * fix format --------- Co-authored-by: Masataka Pocke Kuwabara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RBS file for [email protected]
ref: https://github.com/ammar/regexp_parsers
I added only Regexp::Parser#parser method in this PR.
This gem has other many essential methods.
So, I'm going to split and open PRs including other essential methods in this gem.
Thanks.