activesupport: Delete a dummy definition: Object#sum #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems this definition was added to avoid the trouble on `rbs prototype rb` and refinements. But it was gone away now because `rbs prototype rb` command ignores refinements now. refs: ruby/rbs#487
tk0miya
force-pushed
the
delete_Object_sum
branch
from
159ed29 to
0219861
Compare
|
The reference to #sum has been deleted in 62aadab so we can remove this method definition. |
pocke
approved these changes
Oct 28, 2023
sw-square
pushed a commit
to sw-square/gem_rbs_collection
that referenced
this pull request
Jan 22, 2024
It seems this definition was added to avoid the trouble on `rbs prototype rb` and refinements. But it was gone away now because `rbs prototype rb` command ignores refinements now. refs: ruby/rbs#487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems this definition was added to avoid the trouble on
rbs prototype rband refinements. But it was gone away now becauserbs prototype rbcommand ignores refinements now.refs: ruby/rbs#487