Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activerecord: Add types for strict_loading #755

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Copy link

@dak2 Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Copy link

Thanks for your review, @ksss!

@dak2, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@dak2
Copy link
Contributor Author

dak2 commented Dec 24, 2024

/merge

@dak2 dak2 force-pushed the activerecord/strict_loading branch from 726037e to 4bd699c Compare December 24, 2024 07:15
@dak2
Copy link
Contributor Author

dak2 commented Dec 24, 2024

/merge

Copy link

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers.

See the Actions tab for detail.

@dak2
Copy link
Contributor Author

dak2 commented Dec 24, 2024

@ksss

Could you re-review this pr ?

I rebased main branch to run Test / test_rubocop_yml workflow it was added by #757.
So, re-approve is needed to perform merge action.

@dak2 dak2 requested a review from ksss December 24, 2024 09:01
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Copy link

Thanks for your review, @ksss!

@dak2, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@dak2
Copy link
Contributor Author

dak2 commented Dec 25, 2024

/merge

@github-actions github-actions bot merged commit ccbd2bb into ruby:main Dec 25, 2024
5 checks passed
@dak2 dak2 deleted the activerecord/strict_loading branch December 25, 2024 00:47
@dak2
Copy link
Contributor Author

dak2 commented Dec 25, 2024

@ksss

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants