Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't support some terminal control chars (eg ^u = kill) #650

Closed
zenspider opened this issue Jun 9, 2022 · 7 comments · Fixed by #680
Closed

doesn't support some terminal control chars (eg ^u = kill) #650

zenspider opened this issue Jun 9, 2022 · 7 comments · Fixed by #680

Comments

@zenspider
Copy link
Member

Mac OS terminal

  • ruby -v: ruby 3.1.2p20
  • rdbg -v: rdbg 1.5.0

Describe the bug

I noticed that ^k and ^y work (kill-line and yank) as expected, but was surprised that ^u (unix-line-discard) does not.

To Reproduce

  1. enter debugger
  2. type anything
  3. control-u

Expected behavior

Everything to the left of the cursor should be cleared back to the prompt

@ko1
Copy link
Collaborator

ko1 commented Jun 25, 2022

debug.gem uses Reline which is used by irb for console.
irb doesn't show this issue?

@zenspider
Copy link
Member Author

Definitely shows up in IRB as well. I haven't been using it of late because I find the popups very distracting and haven't dug in to figure out if you can turn it off.

Want me to refile over there?

@st0012
Copy link
Member

st0012 commented Jun 25, 2022

@zenspider Regarding the reline popup, we're already pushing the first PR to address it, which I expect to be merged soon. But we'll still need to make a few other changes to resolve it.

At the mean time, you can disable it by putting IRB.conf[:USE_AUTOCOMPLETE] = false in your PROJECT/.irbrc or ~/.irbrc.

@zenspider
Copy link
Member Author

Thank you. I just found that and am now tweaking out some other config (I've been dragging my own history truncator along for 15+ years)

@zenspider
Copy link
Member Author

ACTUALLY... now that I'm poking around in IRB, this appears fixed. Looking at debug it appears fine too... So I think this was fixed in the latest reline bump:

9997 % ruby -v ; rdbg -v; gem list reline 
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [arm64-darwin21]
rdbg 1.5.0

*** LOCAL GEMS ***

reline (0.3.1, default: 0.3.0)

Can we get @hsbt to tag reline 0.3.1 whenever that was cut?

@st0012
Copy link
Member

st0012 commented Jun 25, 2022

There’s also an issue for the tag: ruby/reline#436

@st0012
Copy link
Member

st0012 commented Jun 27, 2022

@zenspider FYI the tag has been pushed.

ko1 added a commit that referenced this issue Jul 5, 2022
@ko1 ko1 mentioned this issue Jul 5, 2022
@ko1 ko1 closed this as completed in #680 Jul 5, 2022
ko1 added a commit that referenced this issue Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants