Feature/add octet stream content type #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this content type is frequent enough to be added to Grape proper, however it needs tests and to be documented to be merged. Also please squash all your commits. |
akabraham
force-pushed
the
feature/add-octet-stream-content-type
branch
3 times, most recently
from
3d2c153
to
2052ccb
Compare
|
Ok I've added a test for application/octet-stream along with tests for rss, atom, and jsonapi (other untested content-types). Also updated the README. Let me know if this works |
| @@ -2,6 +2,7 @@ | |||
| ============ | |||
|
|
|||
| * Your contribution here. | |||
| * [#745](https://github.com/intridea/grape/pull/745): Added `:binary, application/octet-stream` content-type - [@contributor](https://github.com/akabraham). | |||
There was a problem hiding this comment.
You're not @contrbutor :) Change to @akabraham.
Updated request_response_spec test for new content_type Updated CHANGELOG Added tests for application/octet-stream and other untested content-types Updated README for undocumented content-types. Flipped :binary and :txt order in content_types.rb Removed atom, rss, and jsonapi content-types since they were never properly supported. Updated test for binary content-type.
akabraham
force-pushed
the
feature/add-octet-stream-content-type
branch
from
2052ccb
to
41bd66d
Compare
|
Ok made the changes. Let me know if this is good |
|
Perfect, merging. |
dblock
added a commit
that referenced
this pull request
Sep 3, 2014
…nt-type Feature/add octet stream content type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.