Proposal: extract dsl methods into modules #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great. Before I merge this, I think we should have corresponding specs, even if very basic for each DSL module. This would serve as a placeholder at least for future changes. |
|
@dblock I did at some placeholder specs. I couldn't fill all blanks. |
|
I'll merge and contribute some (got some airplane time next week :)). |
dblock
added a commit
that referenced
this pull request
Aug 12, 2014
Proposal: extract dsl methods into modules
|
Nice :) I will see what I can do too. The good thing is it show's the dependencies of the DSL. The bad thing some PR will now need some refactoring. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to suggest that DSL methods are extracted to seperate modules. This way it is easier to lookup DSL methods and see what I can use for my API definition.