Add param validator for allowed values (intridea/grape#471) #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, it just needs a README update. Also you might want to use Ruby 1.9 syntax, we gave up on 1.8.x. I'll soon go through the codebase and make it all 1.9. |
|
@dblock I've updated the README and converted to the 1.9 hash syntax. Let me know if there are any other changes to be made. |
|
You have to merge from upstream, too, please. There were changes on master. |
|
@dblock is there anything else you'd like me to change? |
|
Merged via e7c44e0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471.