Change order of Rack middleware execution. Fixes issues experienced with JSONP and Grape Entities #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am down with merging this fix. I'd like you to update CHANGELOG, please. |
|
I'll cleanup the test and update the CHANGELOG. Would you like something in the Docs about JSONP - I recall you mentioned it in a prev. thread? |
|
Yes, that would be nice, thank you. |
…likely to be more generic and centered around middleware/formatter etc.)
|
Added a quick link to CORS too... https://github.com/Deckchair/grape/commit/b7f08f2722e61fcfdeb9cadf7aa6d51b01aa2ba9 Anything else? |
|
Updated the title/description of the pull request. |
dblock
added a commit
that referenced
this pull request
Mar 2, 2013
Change order of Rack middleware execution. Fixes issues experienced with JSONP and Grape Entities
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified execution order of Rack middleware.
Added a test for JSONP.
Added a section to the README regarding JSONP and CORS.
Fixes issues encountered with
Grape::Entitybeing processed by JSONP middleware before being processed by the Formatter middleware. See #345 .May fix other content-type header issues and body formatting related issues when using external middlewares.
Related discussions:
#345
#346