Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expanding LOAD_PATH in gemspec #1758

Merged
merged 1 commit into from
May 6, 2018
Merged

Fix expanding LOAD_PATH in gemspec #1758

merged 1 commit into from
May 6, 2018

Conversation

2maz
Copy link
Contributor

@2maz 2maz commented May 4, 2018

Otherwise Grape::VERSION might refer to another, e.g.,
system wide installed gem version

@grape-bot
Copy link

grape-bot commented May 4, 2018

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 danger

2maz added a commit to 2maz/deb_patches that referenced this pull request May 4, 2018
@dblock
Copy link
Member

dblock commented May 4, 2018

Interesting. Care to look at the build failure? Probably unrelated, but lets exclude rails edge in that case.

@2maz
Copy link
Contributor Author

2maz commented May 5, 2018

Bundler could not find compatible versions for gem `"activerecord":
  In rails_edge.gemfile:
    arel was resolved to 10.0.0.pre, which depends on
      activerecord (>= 6.a)

To me, it does not seem to be related.
Issue lies probably in the dependency definition given in "the repository: 'rails/arel'".
Should I update the travis configuration with this PR?

@dblock
Copy link
Member

dblock commented May 5, 2018

It was fixed in #1759, rebase please.

Otherwise Grape::VERSION might refer to another, e.g.,
 system wide installed gem version
@2maz
Copy link
Contributor Author

2maz commented May 6, 2018

updated

@dblock dblock merged commit 9a4b939 into ruby-grape:master May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants