Fixes #1090 #1688
Merged
Fixes #1090 #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ramkumar-kr
commented
Oct 5, 2017
ramkumar-kr
commented
- Add link for documentation published by rubygems in README
- Remove rake task to generate YARD docs
|
Needs changelog please, also remove yard from Gemfile (and elsewhere?) |
ramkumar-kr
force-pushed
the
publish_docs
branch
from
025c413
to
7fcb52c
Compare
|
Done |
dblock
reviewed
Oct 6, 2017
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| #### Features | |||
|
|
|||
| * [#1686](https://github.com/ruby-grape/grape/pull/1686): Avoid coercion of a value if it is valid - [@timothysu](https://github.com/timothysu). | |||
| * [#1688](https://github.com/ruby-grape/grape/pull/1688): Fixes #1090 - [@ramkumar-kr](https://github.com/ramkumar-kr). | |||
There was a problem hiding this comment.
Lets be explicit here, make it "Removed Yard docs".
ramkumar-kr
force-pushed
the
publish_docs
branch
from
7fcb52c
to
326e95e
Compare
- Add link for documentation published by rubygems in README - Remove rake task to generate YARD docs - Remove yard and redcardpet gem as a dependency - Remove .yardopts - Remove ignoring .yardoc directory
ramkumar-kr
force-pushed
the
publish_docs
branch
from
326e95e
to
bbaf9c6
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.