[Bugfix] Handle deeply-nested dependent params #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behind the scenes, each call to `requires` or other params DSL method pushes an entry onto a flat list of validators. The nesting structure that your parameters can take on is tracked as an up-tree separately on each scope, but that relationship isn't used to traverse the validations. So, when I moved the dependency checking out of `should_validate?` and into the actual validation, the `given` dependency stopped taking effect after you nested parameters more than one level deep underneath. To restore the behavior, I made the validation check recursively upwards to see if it should or should not validate that scope.
|
Thanks for this! |
Closed
jdurand
pushed a commit
to jdurand/grape
that referenced
this pull request
Jan 25, 2019
* Repro issue ruby-grape#1659 * [Fix] Handle deeply-nested dependencies with `given`. Behind the scenes, each call to `requires` or other params DSL method pushes an entry onto a flat list of validators. The nesting structure that your parameters can take on is tracked as an up-tree separately on each scope, but that relationship isn't used to traverse the validations. So, when I moved the dependency checking out of `should_validate?` and into the actual validation, the `given` dependency stopped taking effect after you nested parameters more than one level deep underneath. To restore the behavior, I made the validation check recursively upwards to see if it should or should not validate that scope. * Add changelog entry.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1659. The core issue was that param validations are a flat list, and the tree structure was only enforced by the recursion in
should_validate?. When I moved the dependency check into the actual validator, the structure was no longer respected past one level deep. To resolve, I've added a similar recursive check intoParamsScope#meets_dependency?. I also added a few more test cases onto @jnardone's repro to test out the behavior works with arrays and nested arrays.