Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to include an array of modules as helpers #1646

Conversation

pablonahuelgomez
Copy link
Contributor

Changing helpers DSL to allow the inclusion of many modules.
This attempts to bring a better readability, since it seems to be
more intuitive to send a list of modules when the message in
question is called helpers.

Want to move from a syntax like:

helpers MyHelper
helpers MyOtherHelper

To a syntax like:

helpers MyHelper, MyOtherHelper

Changing helpers DSL to allow the inclusion of many modules.
This attemps to bring a better readability, since it seems to be
more intuitive to send a list of modules when the message in
question is called helpers.
@dblock dblock merged commit 037cd3d into ruby-grape:master Jun 12, 2017
@dblock
Copy link
Member

dblock commented Jun 12, 2017

Beautiful. I merged a bit fast it needed a README update. Can you please PR on top @pablonahuelgomez?

@pablonahuelgomez
Copy link
Contributor Author

Sure @dblock, will do! Thanks for merging this PR 👍

@pablonahuelgomez pablonahuelgomez deleted the allow-helpers-to-mix-in-a-list-of-modules branch June 12, 2017 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants