Fix for issue #726 #1589
Fix for issue #726 #1589
Conversation
CHANGELOG.md
Outdated
| @@ -18,6 +18,7 @@ | |||
| * [#1564](https://github.com/ruby-grape/grape/pull/1564): Fix declared params bug with nested namespaces - [@bmarini](https://github.com/bmarini). | |||
| * [#1567](https://github.com/ruby-grape/grape/pull/1567): Fix values validator when value is empty array and apply except to input array - [@jlfaber](https://github.com/jlfaber). | |||
| * [#1569](https://github.com/ruby-grape/grape/pull/1569), [#1511](https://github.com/ruby-grape/grape/issues/1511): Upgrade mustermann-grape to 1.0.0 - [@namusyaka](https://github.com/namusyaka). | |||
| * [#1589](https://github.com/ruby-grape/grape/pull/1589): Fix for issue #726 - [@inclooder](https://github.com/inclooder). | |||
There was a problem hiding this comment.
Describe what the problem is, otherwise users have click on issues in changelog to figure out what the deal is.
…ia format and fallback to default_format only if content-type is not specified.
inclooder
force-pushed
the
OS-45_issue_726
branch
from
68afc5b
to
132f232
Compare
|
@dblock Should be OK |
|
How do you get logging around this? Lost a few days trying to track down why bumping grape blocked a pubsub system, and it's because it's coming in as |
|
The detail is in the HTTP response, but logging the body seems like a bad idea generally, no? Feel free to open a new issue or suggest what we can do here. |
|
Am I correct in my analysis that this changes discards anything set by https://github.com/ruby-grape/grape/blob/master/lib/grape/middleware/formatter.rb#L120-L127 |
|
@AndrewRayCode Why do you think that? If anything was dropped it wasn't a spec-ed behavior. |
This changes should fix issue described in #726.
Default format is used when there is no Content-type.
When Content-type is provided but it's not on the list then the error is thrown.
Normal behavior otherwise.