Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for issue #1578 #1579

Merged
merged 4 commits into from
Feb 19, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/grape/endpoint.rb
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,10 @@ def run
run_filters afters, :after
cookies.write(header)

# The Body commonly is an Array of Strings, the application instance itself, or a File-like object.
#status verifies body presence when DELETE
@body ||= response_object if response_object.present?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the if is redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, i'll remove it


# The Body commonly is an Array of Strings, the application instance itself, or a File-like object
response_object = file || [body || response_object]
Copy link
Member

@dblock dblock Feb 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe body here is the same as @body, so this should be file || body?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's the same. I forgot to remove it. On it 👍
Thanks

[status, header, response_object]
end
Expand Down
33 changes: 33 additions & 0 deletions spec/grape/endpoint_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1149,6 +1149,39 @@ def memoized
end
end

describe 'delete 200, with a return value (no explicit body)' do
it 'responds to /example delete method' do
subject.send(:delete, '/example', anchor: false) do
Copy link
Member

@dblock dblock Feb 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to send these, delete is public, so subject.delete .... I could be wrong.

'deleted'
end
send(:delete, '/example/')
Copy link
Member

@dblock dblock Feb 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, just delete '/example', these are rack helpers. This one I am pretty sure can be done without a send.

expect(last_response.status).to eql 200
expect(last_response.body).not_to be_empty
end
end

describe 'delete 204, with nil has return value (no explicit body)' do
it 'responds to /example delete method' do
subject.send(:delete, '/example', anchor: false) do
nil
end
send(:delete, '/example/')
expect(last_response.status).to eql 204
expect(last_response.body).to be_empty
end
end

describe 'delete 204, with empty array has return value (no explicit body)' do
it 'responds to /example delete method' do
subject.send(:delete, '/example', anchor: false) do
''
end
send(:delete, '/example/')
expect(last_response.status).to eql 204
expect(last_response.body).to be_empty
end
end

describe 'all other' do
%w(post get head put options patch).each do |verb|
it "allows for the anchoring option with a #{verb.upcase} method" do
Expand Down