Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade mustermann-grape to 1.0.0 #1569

Merged
merged 1 commit into from
Mar 5, 2017
Merged

upgrade mustermann-grape to 1.0.0 #1569

merged 1 commit into from
Mar 5, 2017

Conversation

namusyaka
Copy link
Contributor

ref #1511

@grape-bot
Copy link

grape-bot commented Feb 1, 2017 •
edited
Loading

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 danger

@coveralls
Copy link

coveralls commented Feb 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 99.074% when pulling 9eeb2ba on upgrade-mustermann into 081d09b on master.

@dblock
Copy link
Member

dblock commented Feb 1, 2017

That's a very rigid dependency and prevents us from releasing Grape v. next. Would ~> 1.0.0 include the beta?

@dblock
Copy link
Member

dblock commented Feb 1, 2017

I would also add a CHANGELOG line that says that #1511 is fixed by this PR.

@namusyaka
Copy link
Contributor Author

Would ~> 1.0.0 include the beta?

Nope, ~> 1.0.0 does not include beta release.
But maybe we don't have to unify versioning with official mustermann. What do you think?

I would also add a CHANGELOG line that says that #1511 is fixed by this PR.

Fixed.

@dblock
Copy link
Member

dblock commented Feb 1, 2017

I don't think unifying versioning with mustermann is needed, but otherwise I think you should release 1.0 (not a beta) and call it a day. I don't think we should merge this PR until Grape is forward compatible.

@namusyaka
Copy link
Contributor Author

I got your point, it's reasonable.
Okay, I'm going to confirm the plan for releasing mustermann-1.0.0.

@coveralls
Copy link

coveralls commented Feb 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 99.104% when pulling fb26c1b on upgrade-mustermann into d124df7 on master.

@namusyaka namusyaka changed the title upgrade mustermann-grape to 1.0.0.beta2 upgrade mustermann-grape to 1.0.0 Mar 4, 2017
@namusyaka
Copy link
Contributor Author

@dblock mustermann-1.0.0 has been released, so I cut a new release of mustermann-grape-1.0.0.

dblock
dblock reviewed Mar 4, 2017
View reviewed changes
grape.gemspec Outdated
@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
s.license = 'MIT'

s.add_runtime_dependency 'rack', '>= 1.3.0'
s.add_runtime_dependency 'mustermann-grape', '~> 0.4.0'
s.add_runtime_dependency 'mustermann-grape', '1.0.0'
Copy link
Member

@dblock dblock Mar 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ~> 1.0.0 for any minor bug fixes, or it will lock at 1.0 no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Fixed.

@dblock dblock merged commit 4e72d73 into master Mar 5, 2017
@namusyaka namusyaka deleted the upgrade-mustermann branch March 5, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@namusyaka @grape-bot @coveralls @dblock