New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code coverage w/ Coveralls. #1555

Merged

dblock merged 1 commit into ruby-grape:master from dblock:coveralls

Jan 12, 2017

Member

dblock commented Jan 12, 2017

No description provided.

grape-bot commented Jan 12, 2017 •

edited

Loading

	1 Message
📖	We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 danger

dblock force-pushed the coveralls branch from c169dbe to 171db1f Compare

January 12, 2017 17:50

coveralls commented Jan 12, 2017 •

edited

Loading

Changes Unknown when pulling c169dbe on dblock:coveralls into ** on ruby-grape:master**.

coveralls commented Jan 12, 2017 •

edited

Loading

Changes Unknown when pulling 171db1f on dblock:coveralls into ** on ruby-grape:master**.

7 similar comments

coveralls commented Jan 12, 2017

Changes Unknown when pulling 171db1f on dblock:coveralls into ** on ruby-grape:master**.

coveralls commented Jan 12, 2017

Changes Unknown when pulling 171db1f on dblock:coveralls into ** on ruby-grape:master**.

coveralls commented Jan 12, 2017

Changes Unknown when pulling 171db1f on dblock:coveralls into ** on ruby-grape:master**.

coveralls commented Jan 12, 2017

Changes Unknown when pulling 171db1f on dblock:coveralls into ** on ruby-grape:master**.

coveralls commented Jan 12, 2017

Changes Unknown when pulling 171db1f on dblock:coveralls into ** on ruby-grape:master**.

coveralls commented Jan 12, 2017

Changes Unknown when pulling 171db1f on dblock:coveralls into ** on ruby-grape:master**.

coveralls commented Jan 12, 2017

Changes Unknown when pulling 171db1f on dblock:coveralls into ** on ruby-grape:master**.

dblock force-pushed the coveralls branch from 171db1f to b72b262 Compare

January 12, 2017 20:42

coveralls commented Jan 12, 2017 •

edited

Loading

Changes Unknown when pulling b72b262 on dblock:coveralls into ** on ruby-grape:master**.


          Added code coverage w/ Coveralls.

644a4c1

dblock force-pushed the coveralls branch from b72b262 to 644a4c1 Compare

January 12, 2017 20:53

coveralls commented Jan 12, 2017 •

edited

Loading

Changes Unknown when pulling 644a4c1 on dblock:coveralls into ** on ruby-grape:master**.

1 similar comment

coveralls commented Jan 12, 2017 •

edited

Loading

Changes Unknown when pulling 644a4c1 on dblock:coveralls into ** on ruby-grape:master**.

dblock merged commit d9c33bb into ruby-grape:master

Member

LeFnord commented Jan 14, 2017

@dblock would be nice to see it in the other gems, I'm not sure if I can do it 😉

How about using of hound ci, with that the commiter see there rubocop offences and can adapt theyr PRs …
… it would be really nice to use it

Member Author

dblock commented Jan 14, 2017

Yes you can, enabling it in coveralls (login as yourself via github) and the rest is just code as in this PR.

Member Author

dblock commented Jan 14, 2017

I've tried Hound, I personally am not in love with it because it makes rubocop an external thing. But obviously feel free to do it for anything you're maintaining.

dblock deleted the coveralls branch

April 14, 2017 17:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet