Params: Fix coerce_with helper and Arrays types #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,9 +136,13 @@ def infer_type_check(type) | |||
| # Note that this will fail unless a method is also | |||
| # passed, or if the type also implements a parse() method. | |||
| type | |||
| elsif type == [Integer] | |||
There was a problem hiding this comment.
This seems like a 1-off, shouldn't it be that type.is_a?(Enumerable) of 1 simple type, and then it's value.all? of that type?
|
Will need CHANGELOG and possibly README changes. |
|
@dblock Requested changes have been done and the Pull Request is updated |
| @@ -9,6 +9,8 @@ | |||
|
|
|||
| #### Fixes | |||
|
|
|||
| * [#1325](https://github.com/ruby-grape/grape/pull/1325): Params: Fix coerce_with helper with Array types - [@ngonzalez](https://github.com/ngonzalez) | |||
There was a problem hiding this comment.
This is missing a period at the end ;)
|
Looks good. I only have minor text requests and I'll merge. Thanks for the good work. |
…y[String] or Array[Integer]
|
@dblock Thanks for the code review ^ ^ I updated README and CHANGELOG |
dblock
added a commit
that referenced
this pull request
Mar 16, 2016
Params: Fix coerce_with helper and Arrays types
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1324, Allow using
coerce_withwhen type is eitherArray[String]orArray[Integer]