After callback warning #1285
Merged
After callback warning #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| before | ||
| begin | ||
| @app_response = @app.call(@env) | ||
| ensure | ||
| after_response = after | ||
| begin | ||
| error = catch(:error) do |
There was a problem hiding this comment.
is the catch(:error) do rack /grape specific? Otherwise I don't see why to use this instead of re-raising the error?
There was a problem hiding this comment.
you're right, throw is not rescued, so this is not necessary. I removed the extra catch.
|
👍 pls squash |
|
Done. |
| before do | ||
| @warnings = warnings = [] | ||
| Grape::Middleware::Base.class_eval do | ||
| define_method(:warn) { |m| warnings << m } |
There was a problem hiding this comment.
This should be
allow_any_instance_of(Grape::Middleware::Base).to receive(:warn) { |m| warnings << m }Then you don't need an after block.
|
Does need a CHANGELOG entry too, please. |
|
Alright, done 👍 I really should have thought of |
|
|
||
| it 'does show a warning' do | ||
| expect { subject.call({}) }.to raise_error(StandardError) | ||
| expect(@warnings).not_to be_empty |
There was a problem hiding this comment.
No need to change this, but it reads more English to say to_not :)
|
Merged. |
dblock
added a commit
that referenced
this pull request
Feb 23, 2016
railsmith
pushed a commit
to railsmith/grape
that referenced
this pull request
Feb 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1265
See discussion in the issue...