Add webrick to support Ruby 3.x #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks again @takahashim … please can you update the changelog |
|
Thank you! I have rebased it. |
|
👍 |
aliuk2012
added a commit
to alphagov/forms-api
that referenced
this pull request
Nov 7, 2022
grape-swagger 1.5 included "webrick" server in the build as we are using puma server this caused a conflict when rackup ran and returned the following message ruby-grape/grape-swagger#853 ``` .asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.20/lib/bundler/rubygems_integration.rb:308:in `block in replace_bin_path': can't find executable rackup for gem rack (Gem::Exception) ``` We should still use puma because WEBRick is not really fit for production use so we shoudl still stick with puma for local development and production.
aliuk2012
added a commit
to alphagov/forms-api
that referenced
this pull request
Nov 8, 2022
grape-swagger 1.5 included "webrick" server in the build as we are using puma server this caused a conflict when rackup ran and returned the following message ruby-grape/grape-swagger#853 ``` .asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.20/lib/bundler/rubygems_integration.rb:308:in `block in replace_bin_path': can't find executable rackup for gem rack (Gem::Exception) ``` We should still use puma because WEBRick is not really fit for production use so we shoudl still stick with puma for local development and production.
aka-momo
pushed a commit
to aka-momo/grape-swagger
that referenced
this pull request
Feb 8, 2023
Bhacaz
pushed a commit
to Bhacaz/grape-swagger
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.x, webrick is no longer included in the standard distribution.
So add it as a gem so that example will work properly.