Use GitHub Flavored Markdown for parsing the markdown

[jeromegn]

It would really help if we could use GitHub Flavored Markdown. Especially for code snippets.

Since Kramdown uses Coderay for highlighting stuff, it's really hard to customize the highlighting colours (it adds style="color:..." to DOM nodes... not nice to override).

Using GFM really just sets the language attribute on DOM nodes. Syntax highlighting can then be more easily done with front-end libraries like Prism, Rainbow, Highlight.js...

[tim-vandecasteele]

100% agreed, GFM is super.

[etehtsea]

This pr broke compatibility with JRuby because github-markdown has c-extensions.

[tim-vandecasteele]

Merde, that was indeed why I chose kramdown to begin with.

@jeromegn as I agree with your reasoning to change to GFM, what would you think about using https://github.com/jjyr/minidown ? This should give you the code blocks you want, and minidown is pure ruby.

[jeromegn]

Kramdown can do gfm I think.

Maybe disable syntax highlighting?
—
Sent from Mailbox for iPhone

On Tue, Feb 4, 2014 at 7:46 AM, Tim Vandecasteele
[email protected] wrote:

Merde, that was indeed why I chose kramdown to begin with.

@jeromegn as I agree with your reasoning to change to GFM, what would you think about using https://github.com/jjyr/minidown ? This should give you the code blocks you want, and minidown is pure ruby.

Reply to this email directly or view it on GitHub:
https://github.com/tim-vandecasteele/grape-swagger/pull/84#issuecomment-34055721

[tim-vandecasteele]

Apparently they added a GFM parser in kramdown indeed.

Using this now, thanks @etehtsea for noticing, I released 0.7.1 which reverts to kramdown and uses GFM.

[etehtsea]

@tim-vandecasteele great. Thank you!