Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Swagger 1.2 specs more precisely #82

Closed
wants to merge 4 commits into from

Conversation

jeromegn
Copy link
Contributor

@jeromegn jeromegn commented Feb 4, 2014

Awesome library. I took the liberty of forking it a little bit to follow the new Swagger specs correctly.


Resource paths should not include the documentation mount_path.

apis. This is an array of apis available to the caller, and contain the relative path to the API declaration. If no apis are available, an empty array should be returned.

From here: https://github.com/wordnik/swagger-core/wiki/Resource-Listing


Operations with the same path, but different HTTP methods should be listed as one api in the apis property.

All HTTP operations for a particular path should be grouped in a single api object. There should be no duplicate HTTP methods for a single path.

From here: https://github.com/wordnik/swagger-core/wiki/API-Declaration

@tim-vandecasteele
Copy link
Contributor

Great, merged

@jeromegn jeromegn deleted the follow-spec branch February 4, 2014 13:25
@tim-vandecasteele
Copy link
Contributor

Should've done this before, but did you check the change with the relative path with swagger-ui?

It looks like swagger-ui is actually using the basePath as relative path, which causes it to break at my end. (I checked in a small rack testapp in /test in master).

@jeromegn
Copy link
Contributor Author

jeromegn commented Feb 5, 2014

It seems like the example UI here: http://swagger.wordnik.com/ works fine with the same specs.

We follow both correctly I believe. Are you using an old UI? Or did they modify their UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants