Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to configure root element for responses #761

Merged
merged 2 commits into from
Oct 12, 2019

Conversation

bikolya
Copy link
Contributor

@bikolya bikolya commented Oct 4, 2019

It would be nicer to have an option similar to is_array in the desc block instead of using route_setting, but apparently it requires a change in the grape repository similar to this one: ruby-grape/grape#1791

@coveralls
Copy link

coveralls commented Oct 4, 2019

Coverage Status

Coverage decreased (-0.06%) to 98.854% when pulling 577865b on bikolya:add-root-to-responses into 5c24f1b on ruby-grape:master.

@LeFnord
Copy link
Member

LeFnord commented Oct 12, 2019

thanks @bikolya … and sorry for the late reply … after running green I'll mörge it

@LeFnord
Copy link
Member

LeFnord commented Oct 12, 2019

sorry overseen the last line, did you created a PR for grape to support this option?
If not how we should handle it?

@LeFnord LeFnord merged commit 294740b into ruby-grape:master Oct 12, 2019
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Jan 3, 2020
aka-momo pushed a commit to aka-momo/grape-swagger that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants