Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple success responses #747

Merged

Conversation

charanpanchagnula
Copy link
Contributor

This is an attempt to address issue #674.

I didn't update the documentation in the README to specifically state that multiple success responses will be allowed, because swagger already has this feature.

I've added specs, but let me know if you'd like me to add more.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.322% when pulling fa61a3b on charanpanchagnula:multiple-success-responses-674 into 2263ece on ruby-grape:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.322% when pulling fa61a3b on charanpanchagnula:multiple-success-responses-674 into 2263ece on ruby-grape:master.

@coveralls
Copy link

coveralls commented Jun 18, 2019

Coverage Status

Coverage increased (+0.003%) to 99.322% when pulling 79ed996 on charanpanchagnula:multiple-success-responses-674 into 2263ece on ruby-grape:master.

@LeFnord
Copy link
Member

LeFnord commented Jun 19, 2019

Hi @charanpanchagnula … I really like this feature, but please add a bit into the README, maybe on the #response section … thanks

@charanpanchagnula
Copy link
Contributor Author

Hi @charanpanchagnula … I really like this feature, but please add a bit into the README, maybe on the #response section … thanks

I have added the documentation @LeFnord

@LeFnord
Copy link
Member

LeFnord commented Jun 19, 2019

many thanks @charanpanchagnula

@LeFnord LeFnord merged commit 4573a82 into ruby-grape:master Jun 19, 2019
@charanpanchagnula charanpanchagnula deleted the multiple-success-responses-674 branch June 19, 2019 17:42
LeFnord pushed a commit that referenced this pull request Jun 21, 2019
* Allow multiple success responses - Issue# 674

* Adding documentation in README for multiple values in success for response

* Making a slight change in the documentation
ShallmentMo pushed a commit to beansmile/grape-swagger that referenced this pull request Mar 11, 2024
* Allow multiple success responses - Issue# 674

* Adding documentation in README for multiple values in success for response

* Making a slight change in the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants