Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: corrected termsOfService in additional info #720

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Fix: corrected termsOfService in additional info #720

merged 1 commit into from
Oct 29, 2018

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 29, 2018

Closes #718

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.207% when pulling 54bb636 on dblock:fix-tos into 95d5e35 on ruby-grape:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.207% when pulling 54bb636 on dblock:fix-tos into 95d5e35 on ruby-grape:master.

@coveralls
Copy link

coveralls commented Oct 29, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.213% when pulling e5bae1c on dblock:fix-tos into 2457215 on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.207% when pulling 54bb636 on dblock:fix-tos into 95d5e35 on ruby-grape:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.207% when pulling 54bb636 on dblock:fix-tos into 95d5e35 on ruby-grape:master.

LeFnord
LeFnord reviewed Oct 29, 2018
View reviewed changes
lib/grape-swagger/endpoint.rb
version: infos[:version]
title: infos[:title] || 'API title',
description: infos[:description],
termsOfService: infos[:terms_of_service_url],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this is in since year, and nobody saw that 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably nobody cares about TOS ;)

@LeFnord
Copy link
Member

LeFnord commented Oct 29, 2018

think it is better to mörge #717 first, then this one, what did you think?

LeFnord
LeFnord reviewed Oct 29, 2018
View reviewed changes
.travis.yml Outdated
@@ -37,3 +37,4 @@ matrix:
- rvm: 2.3.7
- rvm: ruby-head
- rvm: jruby-head
- env: GRAPE_VERSION=HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think, this can be removed now

@dblock
Copy link
Member Author

dblock commented Oct 29, 2018

💚 @LeFnord

@LeFnord
Copy link
Member

LeFnord commented Oct 29, 2018

thanks @dblock

@LeFnord LeFnord merged commit b9beec2 into ruby-grape:master Oct 29, 2018
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
@dblock @LeFnord
Fix: corrected termsOfService field name in additional info. (ruby-gr…
6daeb18 
…ape#720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeFnord LeFnord LeFnord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dblock @coveralls @LeFnord