issue #584: do not mutate route.path #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFnord
force-pushed
the
master
branch
2 times, most recently
from
2b11193
to
96de759
Compare
- adds changelog entry
kzaitsev
approved these changes
Feb 27, 2017
timlapluie
reviewed
Mar 10, 2017
| @@ -8,15 +8,15 @@ def can_be_moved?(params, http_verb) | |||
| move_methods.include?(http_verb) && includes_body_param?(params) | |||
| end | |||
|
|
|||
| def to_definition(params, route, definitions) | |||
| def to_definition(path, params, route, definitions) | |||
There was a problem hiding this comment.
Wouldn't it be better to append the new param path instead of prepending it? This is a public method so the change could break other code.
florianpilz
reviewed
Mar 10, 2017
| specify 'The original route path is not mutated' do | ||
| route = Struct.new(:version, :path).new | ||
| route.path = '/foo/:dynamic/bar' | ||
| subject.build(route, add_version: true) |
There was a problem hiding this comment.
I would like to see an expectation here as well to see that the path was modified, but route.path was not.
thomet
reviewed
Mar 10, 2017
| version = GrapeSwagger::DocMethods::Version.get(route) | ||
| version = [version] unless version.is_a?(Array) | ||
| Array( | ||
| route.path.split('{')[0].split('/').reject(&:empty?).delete_if do |i| | ||
| path.split('{')[0].split('/').reject(&:empty?).delete_if do |i| |
There was a problem hiding this comment.
I know you don't changed that, but please can we extract this split and reject into a separate method which explains, what it did? It's really hard to understand and a good method name would help with that.
wteuber
reviewed
Mar 10, 2017
| version = GrapeSwagger::DocMethods::Version.get(route) | ||
| version = [version] unless version.is_a?(Array) | ||
| Array( | ||
| route.path.split('{')[0].split('/').reject(&:empty?).delete_if do |i| | ||
| path.split('{')[0].split('/').reject(&:empty?).delete_if do |i| |
There was a problem hiding this comment.
This array initialisation is quite complex and worth abstracting away from Application logic.
LeFnord
added a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
- adds changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.