accepts string as entity #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFnord
force-pushed
the
master
branch
3 times, most recently
from
57ac313
to
17b5a6a
Compare
dblock
reviewed
Oct 31, 2016
| @@ -20,7 +20,7 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency 'bundler' | |||
| s.add_development_dependency 'rack-test' | |||
| s.add_development_dependency 'rack-cors' | |||
| s.add_development_dependency 'rubocop', '0.40.0' | |||
| s.add_development_dependency 'rubocop' # , '0.40.0' | |||
There was a problem hiding this comment.
I think you want to lock this, here or in Gemfile, otherwise it will keep trying to run a newer rubocop and future-failing builds.
|
Looks good, see my rubocop comment otherwise feel free to merge. |
- adds changelog entry - requires min version of rubocop
This was referenced Oct 31, 2016
LeFnord
added a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
- adds changelog entry - requires min version of rubocop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.