Order of header parameters #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see why not. I would spec it as well. |
|
Added test and changelog entry. |
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| #### Fixes | |||
|
|
|||
| * Your contribution here. | |||
| * [#448](https://github.com/ruby-grape/grape-swagger/pull/448): Header parameters are now prepended to the parameter list - [@anakinj](https://github.com/anakinj). | |||
There was a problem hiding this comment.
please move the entry to features, cause it is not a bug 😉
|
👍 … after addressing comment |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
* Prepend the header params instead of appending them * Added test for order of the parameters, headers first * Updated CHANGELOG * Changelog entry from fixes to features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the order of the parameters had changed at some point, nowadays the header parameters are added to the end of the parameter array.
That results in possible headers are located at the end of the list in Swagger UI.
What do you think of always having the possible header parameters at the beginning of the list?