Skip to content

Commit

Permalink
add multi_json to dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
@mach-kernel
mach-kernel committed Jul 11, 2017
1 parent 6b74f28 commit 9da8f40
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions grape-roar.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Gem::Specification.new do |gem|
gem.version = Grape::Roar::VERSION

gem.add_dependency 'grape'
gem.add_dependency 'multi_json'
gem.add_dependency 'roar', '~> 1.1.0'
gem.required_ruby_version = '>= 2.1.0'
end

2 comments on commit 9da8f40

@yuki24
Copy link
Contributor

@yuki24 yuki24 commented on 9da8f40 Oct 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why the multi_json gem is absolutely necessary? It is no longer encounraged to use it today due to this reason: intridea/multi_json#113 (comment)

@dblock
Copy link
Member

@dblock dblock commented on 9da8f40 Oct 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuki24 It should be removed and

grape-roar/lib/grape/roar/formatter.rb

Line 8 in 6b74f28

object.respond_to?(:to_json) ? object.to_json(user_options: { env: env }) : MultiJson.dump(object)
should be rewritten to use Grape::JSON which automatically picks the available library. Feel free to PR.

Please sign in to comment.