Fix the return value of Concurrent.available_processor_count when cpu.cfs_quota_us is -1
#1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Aug 9, 2024
| return nil if max == 0 | ||
| # If the cpu.cfs_quota_us is -1, cgroup does not adhere to any CPU time restrictions | ||
| # https://docs.kernel.org/scheduler/sched-bwc.html#management | ||
| return nil if max == 0 || max == -1 |
There was a problem hiding this comment.
Maybe we should check if max <= 0?
Seems a tiny bit safer and more efficient as we can't interpret a value <= 0 safely.
Could you change to that?
There was a problem hiding this comment.
Thanks for your review. I updated the condition.
|
Thanks and sorry for the bug. |
y-yagi
force-pushed
the
fix_available_processor_count
branch
from
ddf62f6
to
7306b26
Compare
…cpu.cfs_quota_us` is -1 I tried to use `Concurrent.available_processor_count` in `parallel` gem, but we got some feedback `Concurrent.available_processor_count` returned a negative value. grosser/parallel#348 (comment) grosser/parallel#349 (comment) According to the https://docs.kernel.org/scheduler/sched-bwc.html#management, The default value of `cpu.cfs_quota_us` is -1. In that case, cgroup does not adhere to any CPU time restrictions. This PR adds the case of `cpu.cfs_quota_us` is -1 to `#cpu_quota` to return processor count from `Concurrent.available_processor_count` in that case.
y-yagi
force-pushed
the
fix_available_processor_count
branch
from
7306b26
to
7fea31d
Compare
|
I've added a CHANGELOG entry. |
eregon
approved these changes
Aug 10, 2024
|
I released https://github.com/ruby-concurrency/concurrent-ruby/releases/tag/v1.3.4 with this fix |
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use
Concurrent.available_processor_countinparallelgem, but we got some feedbackConcurrent.available_processor_countreturned a negative value.grosser/parallel#348 (comment)
grosser/parallel#349 (comment)
According to the https://docs.kernel.org/scheduler/sched-bwc.html#management, The default value of
cpu.cfs_quota_usis -1. In that case, cgroup does not adhere to any CPU time restrictions.This PR adds the case of
cpu.cfs_quota_usis -1 to#cpu_quotato return processor count fromConcurrent.available_processor_countin that case.