Decouple tests from RabbitMQ

[gnagno]

All the tests are now green without the need to have RabbitMQ running.
I commented out the tests that are testing the behavior of Bunny. I don't this the purpose of this test suite is to test Bunny.

[gjohnson]

So we'll just cross our fingers that it works with RabbitMQ rather than actually test it?

[michaelklishin]

I am very much against such testing. This is outright irresponsible to ship a product that's not tested against what people will run it with in production.

[michaelklishin]

If folks at GoCardless feel like including this, feel free to re-open, but this is a really, really bad idea.
Getting RabbitMQ up and running these days is trivial, especially for Homebrew users.

[hmarr]

It was actually my intention to go the other way - I'd like a lot more tests that hit RabbitMQ (#5) :)

I appreciate you taking the time to contribute, but I'm afraid I'm also not in favour of merging this.

[gnagno]

I would like to motivate my choices, I am not begging to reopen the PR.

I think that since Hutch is depending so strongly on Bunny the main focus of the tests should be the interface between Hutch and Bunny. It would be like, every time we develop a Rails app, if since our models use Activerecord we not only test our models, but also how they persist the data on mysql.... this is something that AR is already doing.

[hmarr]

@gnagno I totally get where you're coming from, but I also think it's really important to ensure that we're using rabbitmq correctly. When building Rails apps, I write loads of tests that hit the DB - testing anything complex queries, testing the integration of multiple components of app, and testing the system as a whole. They may be slow, but they're necessary to have confidence in the test suite.

[ms-ati]

@hmarr 👍 me too.