Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require ostruct explicitly #399

Merged
merged 1 commit into from
May 8, 2024
Merged

Require ostruct explicitly #399

merged 1 commit into from
May 8, 2024

Conversation

sharshenov
Copy link
Contributor

OpenStruct is optional since JSON v 2.7.2

References:

This commit fixes error:

Hutch.connect

gems/hutch-1.2.0/lib/hutch/broker.rb:272:in `api_config': uninitialized constant Hutch::Broker::OpenStruct (NameError)

      @api_config ||= OpenStruct.new.tap do |config|
                      ^^^^^^^^^^

@sharshenov
Require ostruct explicitly
7327344 
`OpenStruct` is optional since `JSON` v 2.7.2

References:
- ruby/json#565
- https://github.com/ruby/ostruct/blob/master/lib/ostruct.rb#L136

This commit fixes error:

```
Hutch.connect

gems/hutch-1.2.0/lib/hutch/broker.rb:272:in `api_config': uninitialized constant Hutch::Broker::OpenStruct (NameError)

      @api_config ||= OpenStruct.new.tap do |config|
                      ^^^^^^^^^^
```
@michaelklishin michaelklishin merged commit 365f279 into ruby-amqp:main May 8, 2024
0 of 4 checks passed
@michaelklishin michaelklishin added this to the 1.3.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sharshenov @michaelklishin