Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unicode slowness issue #776

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Fix Unicode slowness issue #776

merged 2 commits into from
Jul 16, 2021

Conversation

jaapbrasser
Copy link
Contributor

Description

This PR fixes slowness for large datasets when validating whether there is Unicode present. This only affects Windows PowerShell

Related Issue

Resolves #774

Motivation and Context

Slowness needs to be resolved

How Has This Been Tested?

Tested on test cluster and in end-user environment

Screenshots (if appropriate):

image

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy!

@mwpreston mwpreston merged commit c42e40a into devel Jul 16, 2021
@jaapbrasser
Copy link
Contributor Author

That's how we roll @mwpreston

@jaapbrasser jaapbrasser deleted the jaap-webreq branch July 16, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-Rubrikvm issue past updating module from 5.3.0 to 5.3.1
2 participants